Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: Test benchmarks with cython disabled #978

Closed
wants to merge 1 commit into from
Closed

DNM: Test benchmarks with cython disabled #978

wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2024

No description provided.

@bdraco bdraco changed the title Test benchmarks with cython disabled DNM: Test benchmarks with cython disabled Oct 13, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5b4ddc6) to head (1431f80).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #978   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2671      2671           
=========================================
  Hits          2671      2671

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #978 will degrade performances by 41.55%

Comparing bluetooth_discovery (1431f80) with main (5b4ddc6)

Summary

❌ 2 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bluetooth_discovery Change
❌ test_raw_ble_plain_text 23.9 µs 40.8 µs -41.55%
❌ test_raw_ble_plain_text_with_callback 38.8 µs 46.2 µs -16.06%

@bdraco
Copy link
Member Author

bdraco commented Oct 13, 2024

Looks like its working as expected 👍

@bdraco bdraco closed this Oct 13, 2024
@bdraco bdraco deleted the bluetooth_discovery branch October 13, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco